From d01f98f9a0cc158cf6194171f69ee47f99017887 Mon Sep 17 00:00:00 2001
From: Sturdy <91910406+apollo-sturdy@users.noreply.github.com>
Date: Wed, 28 Feb 2024 10:55:20 +0100
Subject: [PATCH] fix: review comments

---
 apps/duckdns/config.json             |  2 --
 apps/duckdns/docker-compose.yml      |  2 +-
 apps/duckdns/metadata/description.md | 14 --------------
 3 files changed, 1 insertion(+), 17 deletions(-)

diff --git a/apps/duckdns/config.json b/apps/duckdns/config.json
index 13916c71..ee16dfe6 100644
--- a/apps/duckdns/config.json
+++ b/apps/duckdns/config.json
@@ -13,8 +13,6 @@
     "source": "https://github.com/linuxserver/docker-duckdns",
     "website": "https://docs.linuxserver.io/images/docker-duckdns/",
     "supported_architectures": ["arm64", "amd64"],
-    "uid": 1000,
-    "gid": 1000,
     "form_fields": [
         {
             "type": "text",
diff --git a/apps/duckdns/docker-compose.yml b/apps/duckdns/docker-compose.yml
index a679877c..067a1ad6 100644
--- a/apps/duckdns/docker-compose.yml
+++ b/apps/duckdns/docker-compose.yml
@@ -12,7 +12,7 @@ services:
       - UPDATE_IP=${DUCKDNS_UPDATE_IP}
       - LOG_FILE=${DUCKDNS_ENABLE_LOG_FILE}
     volumes:
-      - ${APP_DATA_DIR}:/config
+      - ${APP_DATA_DIR}/data:/config
     ports:
       - ${APP_PORT}:80
     restart: unless-stopped
diff --git a/apps/duckdns/metadata/description.md b/apps/duckdns/metadata/description.md
index 00edc73e..c2c41a77 100644
--- a/apps/duckdns/metadata/description.md
+++ b/apps/duckdns/metadata/description.md
@@ -4,20 +4,6 @@
 
 [![duckdns](https://raw.githubusercontent.com/linuxserver/docker-templates/master/linuxserver.io/img/duckdns.png)](https://duckdns.org/)
 
-## Supported Architectures
-
-We utilise the docker manifest for multi-platform awareness. More information is available from docker [here](https://distribution.github.io/distribution/spec/manifest-v2-2/#manifest-list) and our announcement [here](https://blog.linuxserver.io/2019/02/21/the-lsio-pipeline-project/).
-
-Simply pulling `lscr.io/linuxserver/duckdns:latest` should retrieve the correct image for your arch, but you can also pull specific arch images via tags.
-
-The architectures supported by this image are:
-
-| Architecture | Available | Tag |
-| :----: | :----: | ---- |
-| x86-64 | ✅ | amd64-\<version tag\> |
-| arm64 | ✅ | arm64v8-\<version tag\> |
-| armhf | ❌ | |
-
 ## Application Setup
 
 - Go to the [duckdns website](https://duckdns.org/), register your subdomain(s) and retrieve your token